Export cmake config set with namespace #165

ClausKlein · 2023-11-26T17:59:08Z

No description provided.

Use includes with namespace docopt

eaaltonen · 2024-04-16T11:01:58Z

.github/workflows/cmake-multi-platform.yml

@@ -45,31 +45,33 @@ jobs:
            c_compiler: cl

    steps:
-    - uses: actions/checkout@v3
+      - uses: actions/checkout@v3



Would make reviewing easier if whitespace change (in .github/workflows/cmake-multi-platform.yml) were in a separate commit

eaaltonen · 2024-04-16T11:03:10Z

CMakeLists.txt

@@ -41,7 +41,7 @@ set_target_properties(docopt PROPERTIES
  SOVERSION ${PROJECT_VERSION_MAJOR}
 )

-target_include_directories(docopt PUBLIC $<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}/include/docopt> $<INSTALL_INTERFACE:include/docopt>)
+target_include_directories(docopt PUBLIC $<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}/include> $<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>)


AFAICT this would change the include dir from include/docopt to just include, so this would not work.

ClausKlein and others added 3 commits November 26, 2023 18:58

Export cmake config set with namespace

5e0cdcc

Create cmake-multi-platform.yml

ea9009a

Build test and example on CI too

f42bb04

Use includes with namespace docopt

ClausKlein force-pushed the develop branch from f5f725e to f42bb04 Compare November 26, 2023 18:32

eaaltonen reviewed Apr 16, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Export cmake config set with namespace #165

Export cmake config set with namespace #165

ClausKlein commented Nov 26, 2023

eaaltonen Apr 16, 2024

eaaltonen Apr 16, 2024

Export cmake config set with namespace #165

Are you sure you want to change the base?

Export cmake config set with namespace #165

Conversation

ClausKlein commented Nov 26, 2023

eaaltonen Apr 16, 2024

Choose a reason for hiding this comment

eaaltonen Apr 16, 2024

Choose a reason for hiding this comment