-
-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make cli_home volume name dynamic (based on cli image name/version) #1297
base: develop
Are you sure you want to change the base?
Conversation
bin/fin
Outdated
@@ -6176,6 +6182,10 @@ load_configuration () | |||
# https://docs.docker.com/compose/reference/envvars/#compose_convert_windows_paths | |||
export COMPOSE_CONVERT_WINDOWS_PATHS=1 | |||
|
|||
# get cli image version | |||
CLI_IMAGE_VER=$(docker-compose --verbose config --hash="cli" 2>&1 | grep 'docker inspect_image <-' | cut -d"'" -f2 | sed 's#/#-#g;s#:#-#g') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This adds almost 2s to load_configuration()
, which is used in many places in fin.
So this would slow everything down substantially. We need to figure out a different approach.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using docker-compose config
to get the cli image version carries a major performance hit across the board in fin. We have to find a different approach.
e96ccc9
to
1c30737
Compare
Fixes: #787