FIX: Take into account language fallbacks for admin sidebar plugin links #27061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue where I18n.lookup was being used to check if a link had a valid I18n key when the `addAdminSidebarSectionLink` plugin API was used. However this was imperfect -- usually when we do `I18n.t`, we fall back to the default locale (`en`), but if `I18n.lookup` is used we do not do this, so we were removing the link needlessly. This issue was identified via the plugin API's use in https://github.com/discourse/docker_manager c.f. https://meta.discourse.org/t/new-admin-sidebar-wheres-the-update-discourse-button/308213/15?u=martin
pmusaraj
approved these changes
May 17, 2024
|
@pmusaraj yeah not sure, I keep flipping back and forth on this. I do think that plugins should not be able to make the UI look bad, so this is why I kept the check in core. |
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/new-admin-sidebar-wheres-the-update-discourse-button/308213/20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue where
I18n.lookupwas being used tocheck if a link had a valid I18n key when the
addAdminSidebarSectionLinkplugin API was used. However this was imperfect -- usually when we do
I18n.t, we fall back to the default locale (en), but ifI18n.lookupis used we do not do this, so we were removing the linkneedlessly.
This issue was identified via the plugin API's use in https://github.com/discourse/docker_manager
c.f. https://meta.discourse.org/t/new-admin-sidebar-wheres-the-update-discourse-button/308213/15?u=martin