Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEV: Add the registerHomeLogoHrefCallback plugin API #27056

Merged
merged 2 commits into from
May 17, 2024
Merged

DEV: Add the registerHomeLogoHrefCallback plugin API #27056

merged 2 commits into from
May 17, 2024

Conversation

megothss
Copy link
Contributor

The registerHomeLogoHrefCallback API allows setting a callback function that specifies the URL used in the home logo.

@megothss
DEV: Add the 'registerHomeLogoHrefCallback' plugin API
e0b2476 
The registerHomeLogoHrefCallback method allows to set a callback function that specifies the URL used in the home logo.
davidtaylorhq
davidtaylorhq reviewed May 17, 2024
View reviewed changes
Copy link
Member

@davidtaylorhq davidtaylorhq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

Can we try making this new API work for the widget header as well? That way, the migration path will be easier, especially for public themes/plugins which need to work for both old and new headers simultaneously.

@megothss megothss merged commit 501781c into main May 17, 2024
16 checks passed
@megothss megothss deleted the dev/api-set-logo-url-callback branch May 17, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtaylorhq davidtaylorhq davidtaylorhq approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@megothss @davidtaylorhq