[WIP][FIX] option to disable multithreading while multiprocessing #2547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @skoudoro, Thank you for updating ! Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated at 2022-03-04 04:02:02 UTC |
Codecov Report
@@ Coverage Diff @@
## master #2547 +/- ##
==========================================
- Coverage 85.02% 85.02% -0.01%
==========================================
Files 127 127
Lines 17426 17445 +19
Branches 2963 2967 +4
==========================================
+ Hits 14817 14832 +15
Misses 1936 1936
- Partials 673 677 +4
|
arokem
reviewed
Mar 6, 2022
| current_openblas = os.environ.get('OPENBLAS_NUM_THREADS', '') | ||
| current_mkl = os.environ.get('MKL_NUM_THREADS', '') | ||
|
|
||
| # import ipdb; ipdb.set_trace() |
|
|
||
|
|
||
| def disable_np_threads(): | ||
| """Reduce OPENBLAS and MKL thread numbers. |
There was a problem hiding this comment.
Do you want to make the number of threads an argument to this function? Right now, this always reduces to 1, but maybe sometimes we want to reduce down to number of cpus?
Not a bad idea. I will look into it. Also, I will turn this into a work in progress. It needs testing and exploration. Thank you for the feedback! |
skoudoro
changed the title
skoudoro
force-pushed
the
master
branch
7 times, most recently
from
1419292
to
ca6268a
Compare
skoudoro
force-pushed
the
master
branch
3 times, most recently
from
5935e1e
to
765963e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2519. It permits to avoid thread oversubscription. In the close future, we need to improve the design and insert it in the parallel module. Small Notes: the
lokybackend fromjoblibsolve this issue. This fix might be useful for the otherjoblibbackends