Internal-only breaking changes #1096
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nedtwigg
force-pushed
the
feat/cleanup-breaking-changes
branch
from
fe898e8
to
a1974be
Compare
… only used to annnotate errors, which will now done by the lint phase.
…ll become part of linting,
…n't respect `FormatExceptionPolicy` anymore.
…lint paradigm. The old way made it impossible to detect lost tags if `apply` always succeeds.
nedtwigg
force-pushed
the
feat/cleanup-breaking-changes
branch
from
a1974be
to
481aa49
Compare
|
Just a warning that this will get force-pushed to again in the future. Not ready for other PRs to depend on it yet. |
This was referenced Apr 5, 2023
nedtwigg
added
the
pr-archive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've accumulated a little bit of cruft in our internal APIs. Refactoring to support linters is easier if we clean this out first.