Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MasakhaNER1.0 and MasakhaNER2.0 implementation #439

Merged
merged 26 commits into from
Apr 18, 2024
Merged

Conversation

nehapokharel
Copy link

@MichaelRoeder Please review the implementation.

Copy link
Member

@MichaelRoeder MichaelRoeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments with respect to the issue that you faced and potential future issues. You may want to think about how you can further extend your current approach to cover the special case of the word separator that is more than a single white space.

@nehapokharel nehapokharel changed the title WORKINPROGRESS: MasakhaNER1.0 and MasakhaNER2.0 implementation MasakhaNER1.0 and MasakhaNER2.0 implementation Jul 26, 2023
Copy link
Member

@MichaelRoeder MichaelRoeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add some more documentation? Don't forget to add yourself as an author of some of these classes 😉

… features are still part of the text. Added a comment to the test to point to the missing feature.
Copy link
Member

@MichaelRoeder MichaelRoeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelRoeder MichaelRoeder merged commit 76496aa into master Apr 18, 2024
2 of 3 checks passed
@MichaelRoeder MichaelRoeder deleted the masakhaNER branch April 18, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants