-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MasakhaNER1.0 and MasakhaNER2.0 implementation #439
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some comments with respect to the issue that you faced and potential future issues. You may want to think about how you can further extend your current approach to cover the special case of the word separator ፡
that is more than a single white space.
src/test/java/org/aksw/gerbil/dataset/impl/masakha/MasakhaNERDatasetTest.java
Outdated
Show resolved
Hide resolved
src/main/java/org/aksw/gerbil/dataset/impl/conll/GenericCoNLLDataset.java
Outdated
Show resolved
Hide resolved
src/main/java/org/aksw/gerbil/dataset/impl/conll/GenericCoNLLDataset.java
Outdated
Show resolved
Hide resolved
src/main/java/org/aksw/gerbil/dataset/impl/conll/GenericCoNLLDataset.java
Outdated
Show resolved
Hide resolved
src/main/java/org/aksw/gerbil/dataset/impl/masakha/MasakhaNERDataset.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add some more documentation? Don't forget to add yourself as an author of some of these classes 😉
src/test/java/org/aksw/gerbil/dataset/impl/ritter/RitterDatasetTest.java
Show resolved
Hide resolved
src/main/java/org/aksw/gerbil/dataset/impl/masakha/MasakhaNERDataset.java
Show resolved
Hide resolved
src/main/java/org/aksw/gerbil/dataset/impl/conll/GenericCoNLLDataset.java
Show resolved
Hide resolved
src/main/java/org/aksw/gerbil/dataset/impl/conll/GenericCoNLLDataset.java
Outdated
Show resolved
Hide resolved
… features are still part of the text. Added a comment to the test to point to the missing feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@MichaelRoeder Please review the implementation.