Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re #1086 basic time schedule check for watches #1092

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

dgtlmoon
Copy link
Owner

@dgtlmoon dgtlmoon commented Nov 4, 2022

Closes #1086
Todo

  • Validate that 'from' value is less than 'until' (but actually a null value on either is ok)
  • Hook update to set defaults for existing watches (all days on, 00-24 etc) if needed (maybe if 'None' then enable all anyway, on that save it should set the right values, and if 'None' in the loop then assume "OK")
  • How does this play with API updated?
  • Add a much more obvious 'Use default interval and schedule' checkbox
  • Add some function to the Watch model like is_schedule_permitted and hook into the Queue loop
  • configurable timezone (add option "Use system timezone")
  • make timezone apply at app start (or use system timezone)

image

If system TZ is 'utc', and timezone config is None, ask the user if they want to use the browser's tz via some popup (or some link/alert/notification)

const tz = Intl.DateTimeFormat().resolvedOptions().timeZone; console.log(tz);

if they select 'no', set it to UTC?

@dgtlmoon dgtlmoon changed the title Re #1086 basic time schedule limits for watches Re #1086 basic time schedule check for watches Nov 12, 2022
@wrobelda
Copy link

wrobelda commented Feb 7, 2023

Any chances of seeing this in master sometime soon?

@VonZubinski
Copy link

@wrobelda and others who are looking for a solution, consider this temporary approach until the merge conflicts are resolved:

Reduce (carbon) footprints and save on proxy costs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Option to enable/disable site checking in specific days/hours intervals
3 participants