#6017: file_updter_spec context_worrding updates. #9749
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.rubocop_todo.yml
Outdated
| @@ -60,15 +60,14 @@ RSpec/ContainExactly: | |||
| Exclude: | |||
| - 'npm_and_yarn/spec/dependabot/npm_and_yarn/update_checker_spec.rb' | |||
|
|
|||
| # Offense count: 30 | |||
| # Offense count: 8 | |||
| # Configuration parameters: Prefixes, AllowedPatterns. | |||
| # Prefixes: when, with, without | |||
| RSpec/ContextWording: | |||
| Exclude: | |||
| - 'common/spec/dependabot/pull_request_creator/message_builder_spec.rb' | |||
There was a problem hiding this comment.
can all the files be fixed in one go?
jurre
reviewed
May 16, 2024
| @@ -118,7 +118,7 @@ | |||
| .to include("\"statesman\", \"~> 1.2.0\"") | |||
| end | |||
|
|
|||
| context "for a gems.rb setup" do | |||
| context "when for a gems.rb setup" do | |||
There was a problem hiding this comment.
Let's please try to make these sentences flow nicely, the idea of these context blocks is that, stringed together they explain in English what the test is trying to address, and those sentences should flow well, it makes it easier to understand the tests.
So in this case: when using a gems.rb setup for example, that way the entire test will read:
Dependabot::Bundler::FileUpdater##updated_dependency_files the updated gemfile when using a gems.rb setup, it delegates to the GemfileUpdater
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.