feat(www): playground #1182
feat(www): playground #1182
Conversation
www/static/deno_lint.js
Outdated
| @@ -0,0 +1,240 @@ | |||
| let wasm; | |||
There was a problem hiding this comment.
Is there a way we could have this js file, the wasm file, and the .d.ts file built when creating the website? Then we don't need to keep updating these and they don't bloat the repository.
There was a problem hiding this comment.
Yeah I was thinking about that, and put it off for the moment to focus on the implementation part. I'll try to find a way to achieve continuous delivery.
There was a problem hiding this comment.
Thinking about it a little bit further, I'd prefer to have developers commit the wasm files into the repo instead of relying on CI to build them, mostly because building them in CI would require configuration changes in Deno Deploy. Of course we could do that, but I think we can do so later if it's really needed (for instance we may want to do AoT build for fresh, which can be done together with wasm build in CI)
|
That's cool! Couple of remarks:
|
|
|
@sigmaSd Thanks for the feedback. What do you mean by "not understood by the lsp"? Like there's no completion options showing up when you put |
|
It looks like this |
|
I made several updates and I think now it's ready for review again. PR description has been updated too, but here's a quick summary:
|
| @@ -4,19 +4,25 @@ | |||
| "build": "deno run -A dev.ts build", | |||
| "preview": "deno run -A main.ts" | |||
| }, | |||
| "lock": false, | |||
| "lock": true, | |||
There was a problem hiding this comment.
Note for reviewers: using libraries from jsr seems to require this
| let maybe_file_path = ctx.specifier().to_file_path().ok(); | ||
| let file_stem = maybe_file_path | ||
| .as_ref() | ||
| .and_then(|p| p.file_stem()) |
There was a problem hiding this comment.
for reviewers: Url's to_file_path method isn't provided for wasm32-unknown-unknown. As a workaround, we extract the last segment from specifier's path part, and treat it as a file name.
This implements a playground to lint.deno.land where we can write random source code and see the diagnostics right away.
Currently the wasm file and its glue code are generated locally and committed to the repo, which means that we need to run the manual updating process (just running
deno task wasmbuild) every time we make changes to the linter. We could automate it by moving this process inside CI, but this isn't done here because that would require changing build settings in Deno Deploy too. Instead, we add a step to CI to check if the wasm files committed to the repo are up-to-date.You can try it out at https://deno-lint--playground.deno.dev/playground
Demo
CleanShot.2024-05-06.at.10.32.06.mp4