Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly fixed overrides in gitattribute for protobuffer text files #8920

Merged

Conversation

redoak
Copy link
Contributor

@redoak redoak commented May 14, 2024

Replaced use of alias text-proto in gitattribute linguist-language, since it doesn't work.

This is a follow-up to my PR #8901 from last week.

I have tested this in my own repo. FYI, for me it sometimes takes a few reloads of the Github file browser to show the new syntax highlighting.

skip release notes

@britzl
Copy link
Contributor

britzl commented May 15, 2024

Replaced use of alias text-proto in gitattribute linguist-language, since it doesn't work.

Ok, unfortunate, but good to hear that it works now. I see now that Protocol-Buffer-Text-Format is indeed the correct name:

https://github.com/github-linguist/linguist/blob/master/lib/linguist/languages.yml#L5492

skip release notes

Assign the label skip release notes to exclude this from generated release notes.

@britzl britzl merged commit e033f6c into defold:dev May 15, 2024
1 check passed
@redoak
Copy link
Contributor Author

redoak commented May 15, 2024

Assign the label skip release notes to exclude this from generated release notes.

I don't appear to have permissions to add labels. Github docs says it requires triage access. Perhaps it's a good thing that not just anyone can come in and add or remove a million labels though.

@britzl
Copy link
Contributor

britzl commented May 15, 2024

Assign the label skip release notes to exclude this from generated release notes.

I don't appear to have permissions to add labels. Github docs says it requires triage access. Perhaps it's a good thing that not just anyone can come in and add or remove a million labels though.

Good point!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants