Made changes to image transformer. #3975
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbharath
reviewed
May 15, 2024
| images = [Image.fromarray(x).resize(self.size) for x in images] | ||
| return np.array(images), y, w | ||
|
|
||
| if self.transform_X: |
There was a problem hiding this comment.
@aaronrockmenezes Can you add a unit test for the new functionality?
rbharath
reviewed
May 20, 2024
| @@ -1943,25 +1943,36 @@ def UG_to_DAG(self, sample: ConvMol) -> List: | |||
|
|
|||
|
|
|||
| class ImageTransformer(Transformer): | |||
| """Convert an image into width, height, channel | |||
| """ | |||
| Transforms images to a specified size. | |||
|
|
|||
There was a problem hiding this comment.
Can you add a usage example here?
There was a problem hiding this comment.
Also, can you expand the docstring to be more informative?
rbharath
reviewed
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current Image Transform uses a scipy method that has been dropped and is no longer functional.
I've added the ImageTransformer method to allow Resizing of images within ImageDatasets (or NumpyDatasets).
Both input data (X) and labels (y) can be transformed.
Uses only Pillow.
Type of change
Please check the option that is related to your PR.
Checklist
yapf -i <modified file>and check no errors (yapf version must be 0.32.0)mypy -p deepchemand check no errorsflake8 <modified file> --countand check no errorspython -m doctest <modified file>and check no errors