Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change interface reinit values #17032

Merged
merged 1 commit into from
May 22, 2024

Conversation

jh66637
Copy link
Contributor

@jh66637 jh66637 commented May 16, 2024

@bangerth @kronbichler
As discussed in #17017

I will mark this as WIP until I checked that everything works.

Copy link
Member

@kronbichler kronbichler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this. This looks very reasonable (and is also more efficient).

@@ -0,0 +1,3 @@
Fixed: Only pass the sizes of quadratures instead of vectors of Quadrature objects to FERemoteEvaluationCommunicator::reinit_faces().
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need this. FERemoteEvaluationCommunicator is a new feature.

@jh66637 jh66637 force-pushed the change_interface_reinit_values branch 2 times, most recently from 5e926a5 to 644330d Compare May 17, 2024 15:21
@jh66637 jh66637 changed the title [WIP] Change interface reinit values Change interface reinit values May 17, 2024
@jh66637 jh66637 marked this pull request as ready for review May 17, 2024 21:38
@kronbichler
Copy link
Member

/rebuild

@masterleinad
Copy link
Member

fe_remote_evaluation_01 is failing.

@bangerth bangerth added this to the Release 9.6 milestone May 21, 2024
@jh66637 jh66637 force-pushed the change_interface_reinit_values branch from 644330d to c1f6d13 Compare May 21, 2024 17:09
Copy link
Member

@kronbichler kronbichler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failure is spurious and after all serial tests passed, let me merge.

@kronbichler kronbichler merged commit 245a90c into dealii:master May 22, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants