Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0 Adding add ci.tbl summary() #1666

Merged
merged 16 commits into from
Jun 4, 2024
Merged

v2.0 Adding add ci.tbl summary() #1666

merged 16 commits into from
Jun 4, 2024

Conversation

ddsjoberg
Copy link
Owner

@ddsjoberg ddsjoberg commented May 17, 2024

  • Adding the add_ci() function.

closes #1569


Reviewer Checklist (if item does not apply, mark is as complete)

  • Ensure all package dependencies are installed by running renv::install()
  • PR branch has pulled the most recent updates from master branch. Ensure the pull request branch and your local version match and both have the latest updates from the master branch.
  • If an update was made to tbl_summary(), was the same change implemented for tbl_svysummary()?
  • If a new function was added, function included in _pkgdown.yml
  • If a bug was fixed, a unit test was added for the bug check
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features. Review coverage with withr::with_envvar(new = c("NOT_CRAN" = "true"), covr::report()). Begin in a fresh R session without any packages loaded.
  • R CMD Check runs without errors, warnings, and notes
  • usethis::use_spell_check() runs with no spelling errors in documentation

When the branch is ready to be merged into master:

  • Update NEWS.md with the changes from this pull request under the heading "# gtsummary (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • Increment the version number using usethis::use_version(which = "dev")
  • Run codemetar::write_codemeta()
  • Run usethis::use_spell_check() again
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge".

@zdz2101
Copy link
Collaborator

zdz2101 commented May 21, 2024

@ddsjoberg you hand wrote/programmed the formulas for each method or used stats package:

so for "exact" which is Clopper-Pearson, the proportion_ci_clopper_pearson() in cardx uses stats::binom.test()
and for "asymptotic" which is Agresti-Coull (???) the proportion_ci_agresti_coull() in cardx is handwritten

in fact the Hmisc library is not used anywhere in cardx I swear I thought I saw it somewhere but perhaps I was looking at gtsummary at the time

Copy link
Collaborator

@zdz2101 zdz2101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple things, I think its pretty intuitive/makes plenty of sense, have to try pretty hard to "break" something

R/add_ci.R Show resolved Hide resolved
R/add_ci.R Outdated Show resolved Hide resolved
DESCRIPTION Outdated Show resolved Hide resolved
R/add_ci.R Outdated Show resolved Hide resolved
R/add_ci.R Show resolved Hide resolved
R/add_ci.R Show resolved Hide resolved
@ddsjoberg ddsjoberg requested a review from zdz2101 June 3, 2024 23:39
@ddsjoberg ddsjoberg merged commit 0343d96 into v2.0 Jun 4, 2024
9 checks passed
@ddsjoberg ddsjoberg deleted the v2.0-add_ci.tbl_summary branch June 4, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants