Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Remove concurrency/cancellation check on pr-check as it's useless [skip ci] #6214

Merged
merged 1 commit into from
May 19, 2024

Conversation

rfay
Copy link
Member

@rfay rfay commented May 18, 2024

The Issue

Since we introduced the concurrency check, we've been getting useless emails about the pr-check concurrency.

Remove it.

@rfay rfay requested a review from a team as a code owner May 18, 2024 19:47
@rfay rfay merged commit d824ffe into ddev:master May 19, 2024
4 checks passed
@rfay rfay deleted the 20240518_remove_cancel_on_pr_check branch May 19, 2024 12:50
@tyler36
Copy link
Collaborator

tyler36 commented May 20, 2024

There is a discussion to allow disabling the notification but no resolution yet. https://github.com/orgs/community/discussions/13015

This MR removes the Github's concurrecy feature but did not restore the previous method right?
We should re-instate the old method.

@rfay rfay changed the title build: Remove concurrency/cancellation check on pr-build as it's useless [skip ci] build: Remove concurrency/cancellation check on pr-check as it's useless [skip ci] May 20, 2024
@rfay
Copy link
Member Author

rfay commented May 20, 2024

Thanks for paying attention!

The only workflow affected here is pr-check (I said in the title pr-build, but I had the wrong one).

pr-check's only annoying job is to see if the title matches the requirements and to apply labels. So it runs quickly and does no damage if it isn't cancelled.

I could live with just removing it, personally. There is hope that we could use the PR title more successfully in the future, but we definitely don't need to worry about auto-cancellation on concurrency for this one IMO.

None of the more important workflows were affected by this.

@rfay
Copy link
Member Author

rfay commented May 20, 2024

This one is particularly annoying because it triggers when you actually change the PR title, for example.

This is mentioned in https://github.com/orgs/community/discussions/13015#discussioncomment-9330564 (thanks for the pointer to the discussion).

I just realized that the emails even fire when you MANUALLY cancel the workflow, not just if it was from a cancel-in-progress in the YML.

I do not need an email for an action I just manually undertook, it would be great if we could see some movement on this. It is really hard for me to notice any actual failures amongst all the cancelled ones.

jonesrussell pushed a commit to jonesrussell/ddev that referenced this pull request Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants