-
-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not validate config in ddev clean, delete -O, stop -U #6209
Conversation
Download the artifacts for this pull request:
See Testing a PR. |
cb6943f
to
279568e
Compare
I'm not sure, but maybe we don't need the validation in |
I would like |
Good idea and doesn't require much change, done. |
485c0fb
to
1be4a49
Compare
1be4a49
to
10e45b0
Compare
Rebased. I was testing and the problems mentioned in the OP are gone... because #6208 was fixed :) |
Yes, that's right, now you have to manually break the config. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a really nice improvement, thanks! This has been a piece of friction for DDEV users for a long time. And allowing deletion of non-existing projects (getting rid of their databases and mutagen state) has been on my personal to-do list for some time.
The Issue
While testing #6208 I noticed a regression in:
And you are stuck with
ddev stop --unlist d10
until you manually clean~/.ddev/project_list.yaml
(or runddev list
)Also the same problem occurs when you are working on some new project type, then you change the DDEV binary and try to delete the test project with this new type, for example, you have
foobar
type:And there is no way to
ddev delete -Oy
until you fix the config.How This PR Solves The Issue
Do not run
ValidateConfig()
on a command with project arguments that don't actually need validation:ddev clean
ddev delete --omit-snapshot
ddev stop --unlist
The general idea is that we don't need to check the config if we delete something (I think it's annoying, just let me delete it, I don't care), and sometimes users can get stuck in a loop and we don't want that.
Allows to delete non-existent projects with
ddev delete -O
.Manual Testing Instructions
And check Docker volumes and the contents of
ddev-global-cache
for:Automated Testing Overview
Related Issue Link(s)
Release/Deployment Notes