fix: clear omit_containers config with empty flag, fixes #6140 #6202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request:
See Testing a PR.
|
|
Thanks for this! Could you please evaluate the |
|
Rebased, looking forward to your work on this. |
|
Hoping you can take a look, it would be good to get these things taken care of together. Thanks! |
|
Rebased. |
jonesrussell
force-pushed
the
omit-containers
branch
from
f8ecb71
to
d0c2c9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
ddev config --omit-containers=""doesn't removeomit_containersfrom.ddev/config.yamlas expected (#6140).Solution
This PR clears
omit-containerswhen an empty string is passed. It uses theChangedmethod, consistent with the global version of the command. Changes are made inhandleMainConfigArgsincmd/ddev/cmd/config.go.Testing
Manual testing involves running
ddev config --omit-containers=dbandddev config --omit-containers=""and checking.ddev/config.yaml. Automated tests will be added to verify the flag's functionality.Related Issues
Fixes issue #6140.
Deployment
No special deployment actions needed. This change doesn't affect other code.