Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbeaver/pro#2567 Add link to the database documentation in the connection window #32638

Conversation

HocKu7
Copy link
Contributor

@HocKu7 HocKu7 commented May 14, 2024

Have added all link for CE version. Links for other versions will be added in the future sprints

@HocKu7 HocKu7 force-pushed the dbeaver/pro#2567-add-link-to-the-database-documentation-in-the-connection-window branch 2 times, most recently from 1711378 to 953124c Compare May 14, 2024 15:27
@@ -31,6 +31,7 @@
category="AWS"
webURL="https://docs.aws.amazon.com/athena/latest/ug/connect-with-jdbc.html"
propertiesURL="https://s3.amazonaws.com/athena-downloads/drivers/JDBC/SimbaAthenaJDBC-2.0.25.1001/doc/Simba+Athena+JDBC+Connector+Install+and+Configuration+Guide.pdf"
driverDocumentationURL="Database-driver-Amazon-Athena"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say it's not a driver, but database documentation.
Also it's not an url, but it's suffix :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

databaseDocumentationSuffixURL?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds better for me

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ticket is already in Ready For QA, so maybe just left it as is

@Matvey16
Copy link
Member

Location of the link is incosistent between new and existing connection and also it feels like the position in new connection is out of place

Existing connection
dbeaver_L8aOXdsYdk

New connection
dbeaver_UodcldHv5K

@arhayka
Copy link
Member

arhayka commented May 15, 2024

image

It would be great to improve the link text and position.

  1. Driver Documentation —> Database documentation
  2. Add (i) icon before this link and move this to the right.
  3. You can user variables in connection parameters —> Connection variables information

@HocKu7 HocKu7 force-pushed the dbeaver/pro#2567-add-link-to-the-database-documentation-in-the-connection-window branch from 561fd4c to 811ca15 Compare May 16, 2024 11:11
@HocKu7
Copy link
Contributor Author

HocKu7 commented May 16, 2024

Database documentation and the change of name of 'You can user variables in connection parameters ' were added only in English and Russian language in the pr

@HocKu7 HocKu7 force-pushed the dbeaver/pro#2567-add-link-to-the-database-documentation-in-the-connection-window branch from 811ca15 to c6f4d8e Compare May 16, 2024 11:32
@E1izabeth
Copy link
Member

I think it would be better to remove the translations in other languages.

@HocKu7 HocKu7 force-pushed the dbeaver/pro#2567-add-link-to-the-database-documentation-in-the-connection-window branch from 279a247 to 78c2514 Compare May 16, 2024 15:21
@Matvey16
Copy link
Member

Matvey16 commented May 20, 2024

There is a bug where wheather the link would appear (in connection creation) somehow depends on which driver you chose first.
For example in a case where I open the wizard and

  1. Select Netezza
  2. Click Back
  3. Select Postgres (Old)

For both of those drivers there would be a link to documentation, but it would lead to a Netezza page in both cases

dbeaver_tF4bxcMNtO.mp4

But if I close the wizard, open a bew one and

  1. Select Postgres (Old)
  2. Click Back
  3. Select Netezza

Both of them would not show a link to documentation

dbeaver_gKG8JtTUJy.mp4

I've used Postgres (Old) as an example that somehow breaks the UI, but there are actually other drivers that do the same.

@HocKu7 HocKu7 force-pushed the dbeaver/pro#2567-add-link-to-the-database-documentation-in-the-connection-window branch 2 times, most recently from 7938e96 to bc2de49 Compare May 21, 2024 12:04
@Matvey16
Copy link
Member

There are pages for Databricks and Redshift in our wiki, but there are now links for those drivers on the connection page

@HocKu7 HocKu7 force-pushed the dbeaver/pro#2567-add-link-to-the-database-documentation-in-the-connection-window branch from bc2de49 to ba4469e Compare May 21, 2024 14:51
@Matvey16
Copy link
Member

Verified

@serge-rider serge-rider merged commit 6a7c794 into devel May 21, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants