-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dbeaver/pro#2567 Add link to the database documentation in the connection window #32638
dbeaver/pro#2567 Add link to the database documentation in the connection window #32638
Conversation
1711378
to
953124c
Compare
@@ -31,6 +31,7 @@ | |||
category="AWS" | |||
webURL="https://docs.aws.amazon.com/athena/latest/ug/connect-with-jdbc.html" | |||
propertiesURL="https://s3.amazonaws.com/athena-downloads/drivers/JDBC/SimbaAthenaJDBC-2.0.25.1001/doc/Simba+Athena+JDBC+Connector+Install+and+Configuration+Guide.pdf" | |||
driverDocumentationURL="Database-driver-Amazon-Athena" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say it's not a driver, but database documentation.
Also it's not an url, but it's suffix :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
databaseDocumentationSuffixURL?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds better for me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ticket is already in Ready For QA, so maybe just left it as is
plugins/org.jkiss.dbeaver.model/src/org/jkiss/dbeaver/model/connection/DBPDriver.java
Outdated
Show resolved
Hide resolved
...i.editors.connection/src/org/jkiss/dbeaver/ui/dialogs/connection/ConnectionPageAbstract.java
Outdated
Show resolved
Hide resolved
...i.editors.connection/src/org/jkiss/dbeaver/ui/dialogs/connection/ConnectionPageAbstract.java
Outdated
Show resolved
Hide resolved
561fd4c
to
811ca15
Compare
Database documentation and the change of name of 'You can user variables in connection parameters ' were added only in English and Russian language in the pr |
811ca15
to
c6f4d8e
Compare
I think it would be better to remove the translations in other languages. |
...i.editors.connection/src/org/jkiss/dbeaver/ui/dialogs/connection/ConnectionPageAbstract.java
Outdated
Show resolved
Hide resolved
...i.editors.connection/src/org/jkiss/dbeaver/ui/dialogs/connection/ConnectionPageAbstract.java
Outdated
Show resolved
Hide resolved
279a247
to
78c2514
Compare
plugins/org.jkiss.dbeaver.registry/src/org/jkiss/dbeaver/registry/RegistryConstants.java
Outdated
Show resolved
Hide resolved
plugins/org.jkiss.dbeaver.registry/src/org/jkiss/dbeaver/registry/driver/DriverDescriptor.java
Show resolved
Hide resolved
There is a bug where wheather the link would appear (in connection creation) somehow depends on which driver you chose first.
For both of those drivers there would be a link to documentation, but it would lead to a Netezza page in both cases dbeaver_tF4bxcMNtO.mp4But if I close the wizard, open a bew one and
Both of them would not show a link to documentation dbeaver_gKG8JtTUJy.mp4I've used Postgres (Old) as an example that somehow breaks the UI, but there are actually other drivers that do the same. |
7938e96
to
bc2de49
Compare
There are pages for Databricks and Redshift in our wiki, but there are now links for those drivers on the connection page |
bc2de49
to
ba4469e
Compare
Verified |
Have added all link for CE version. Links for other versions will be added in the future sprints