-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dbeaver/dbeaver#20602 load controls for extra pages #22616
base: devel
Are you sure you want to change the base?
dbeaver/dbeaver#20602 load controls for extra pages #22616
Conversation
bf8a6f9
to
782a9e9
Compare
...g.jkiss.dbeaver.core/src/org/jkiss/dbeaver/ui/dialogs/connection/ConnectionPageSettings.java
Show resolved
Hide resolved
@@ -28,4 +28,17 @@ public interface IDialogPageProvider { | |||
@Nullable | |||
IDialogPage[] getDialogPages(boolean extrasOnly, boolean forceCreate); | |||
|
|||
/** | |||
* Pages what should be saved during creation, even if they were |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Pages what should be saved during creation, even if they were | |
* Pages that should be saved during creation, even if they were |
* null if no additional pages should be created. | ||
*/ | ||
@Nullable | ||
default IDialogPage[] getRequiredDialogPages() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Method name is not descriptive enough. I couldn't understand what does it mean, until I read the comment. I'd propose something like getPagesContainingSettings
. Maybe you can figure out better name, but don't left just as is, please. It's not clear what does Required means - required for what?
@@ -192,6 +191,31 @@ public void activatePage() { | |||
//getContainer().updateTitleBar(); | |||
} | |||
|
|||
private void createAdditionalRequiredPages() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I doubt about calling this method create..
. I would rather expact to call it like load..
or smth like that. Yes, you call createControl method, but the control is not visible and so on..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still concerned with the proposed solution.
Now control for extra pages for Oracle and Postgre are loaded during main page initialization which should allow properties to be saved even if no page were loaded previously
Closes #20602