Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SiteToc to MobileNav #1069

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

marcchehab
Copy link
Contributor

This PR adds the SiteToc to the MobileNav. It also fixes double type declarations in MobileNav by importing the interfaces from Nav. Adding SiteToc was then just a matter of uncommenting code that was there already.

Recording.2024-01-21.125123.mp4

Copy link

changeset-bot bot commented Jan 21, 2024

⚠️ No Changeset found

Latest commit: 1a8e7ac

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

6 Ignored Deployments
Name Status Preview Comments Updated (UTC)
portaljs-alan-turing ⬜️ Ignored (Inspect) Visit Preview Jan 21, 2024 11:52am
portaljs-ckan ⬜️ Ignored (Inspect) Visit Preview Jan 21, 2024 11:52am
portaljs-git-example ⬜️ Ignored (Inspect) Visit Preview Jan 21, 2024 11:52am
portaljs-learn ⬜️ Ignored (Inspect) Visit Preview Jan 21, 2024 11:52am
portaljs-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 21, 2024 11:52am
site-portaljs ⬜️ Ignored (Inspect) Visit Preview Jan 21, 2024 11:52am

Copy link

vercel bot commented Jan 21, 2024

@marcchehab is attempting to deploy a commit to the Datopian Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@olayway olayway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you! 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants