Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor loading of extensions: load all by default but allow for configuration #7597

Draft
wants to merge 2 commits into
base: maint
Choose a base branch
from

Conversation

yarikoptic
Copy link
Member

It should

  • make it easier for naive users to use DataLad -- typically they just install an extension and get extension functionality immediately exposed, e.g. like was reported in
  • retain capability to whitelist a list of extensions to consider via datalad.extensions.load configuration variable
    • an option is to deprecate it in favor of datalad.extensions.enable which would be more descriptive
  • make it uniform across all points which consider extensions, not only for loading
    • or are there specific use-cases where you want to have extension functionality available but not "loaded"?

It will be guided by the same datalad.extensions.load ATM,
although I think we should refactor it in the long(er) term into
datalad.extensions.enable  which would be more descriptive of the
purpose.

IMHO we should either consider entire extension or not consider it at all.
ATM we have diverging logic which leads to confusion as "I have installed extension X
and it works, but I installed extension Y and its effects are not there"
@yarikoptic yarikoptic added the semver-minor Increment the minor version when merged label May 13, 2024
Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 91.30%. Comparing base (fda2048) to head (e53242b).

Files Patch % Lines
datalad/support/entrypoints.py 81.81% 4 Missing ⚠️
datalad/local/wtf.py 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            maint    #7597      +/-   ##
==========================================
- Coverage   91.30%   91.30%   -0.01%     
==========================================
  Files         325      325              
  Lines       43459    43478      +19     
  Branches     5781     5786       +5     
==========================================
+ Hits        39682    39698      +16     
- Misses       3762     3765       +3     
  Partials       15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-minor Increment the minor version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant