-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH add --data option to get command, matching push one #7476
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #7476 +/- ##
==========================================
+ Coverage 90.61% 91.55% +0.93%
==========================================
Files 325 325
Lines 43405 43449 +44
Branches 0 5826 +5826
==========================================
+ Hits 39333 39781 +448
+ Misses 4072 3653 -419
- Partials 0 15 +15
☔ View full report in Codecov by Sentry. |
@@ -1000,7 +1025,7 @@ def __call__( | |||
continue | |||
yield res | |||
|
|||
if not get_data: | |||
if data=='nothing' or not get_data: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel that introduction of data
potentially makes get_data
obsolete and thus require replacement/deprecation cycle and that could be taken as a good thing since get_data
flag semantic is already shown to be "inconsistent" (get_data
in python but --no-data
in CLI).
But -n
(AKA --no-data
) is used heavily in handbook etc, and is a convenient shortcut to signal --data=nothing
.
So, I think that is how -n|--no-data
should be promoted - that it is a shortcut for data="nothing"
and there should be explicit statement that data
option is ignored if --no-data
is provided.
But also let's wait for others to chime in
Code Climate has analyzed commit 4e4344f and detected 0 issues on this pull request. View more on Code Climate. |
I have placed this PR on the agenda of the next dev call for October 24th, hopefully we can revive the discussion. :) |
Partially addresses #7468 by adding a
--data
option toget
command with values similar topush
command.Passes
--want-get here
togit-annex get
ifauto
orauto-if-wanted
(and preferred content is set) values are passed.PR checklist