Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF?: add more obscure parts into filename -- [] could be used in globs #7362

Draft
wants to merge 1 commit into
base: maint
Choose a base branch
from

Conversation

yarikoptic
Copy link
Member

With @Michael-Sun we ran into some odd case with git-annex, where a file

Yarik[8910].ssh.txt failed to be git annex get"ed which gave me idea to test for these extra cases in the most obscure filename case

With @Michael-Sun we ran into some odd case with git-annex, where a file

Yarik[8910].ssh.txt  failed to be  git annex get"ed  which gave me idea to
test for these extra cases in the most obscure filename case
@yarikoptic
Copy link
Member Author

eh, there are some hits:

=========================== short test summary info ============================
FAILED ../datalad/local/tests/test_run_procedure.py::test_quoting - ValueError: Cannot find procedure with name 'just2args'
FAILED ../datalad/support/tests/test_gitrepo.py::test_gitattributes - AssertionError: assert {'sec.key': '... 'tag': False} == {'sec.key': '...this': 'that'}
  Omitting 2 identical items, use -vv to show
  Right contains 1 more item:
  {'this': 'that'}
  Full diff:
  - {'sec.key': 'val', 'tag': False, 'this': 'that'}
  ?                                ----------------
  + {'sec.key': 'val', 'tag': False}
FAILED ../datalad/support/tests/test_sshconnector.py::test_ssh_copy - datalad.runner.exception.CommandError: CommandError: 'scp -o ControlPath=/home/travis/.cache/datalad/sockets/8ef0c2f1 'datalad-test:/tmp/datalad_temp_test_ssh_copy7ujhgeoz.c\ opy/\ \|\;\&%b5{}\'"'"'\"\<\>[][12]ΔЙקم๗あ\ .datc\ 2' /tmp/datalad_temp_test_ssh_copy7ujhgeoz' failed with exitcode 1 [err: 'protocol error: filename does not match request']
= 3 failed, 1224 passed, 59 skipped, 4 xfailed, 19 warnings in 1719.62s (0:28:39) =

@yarikoptic yarikoptic added the semver-tests Changes only affect tests, no impact on version label Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-tests Changes only affect tests, no impact on version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant