Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boost minimal git annex version #7232

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

yarikoptic
Copy link
Member

see individual commits, ref: #6847 (closed by a specific commit)

@yarikoptic yarikoptic added the semver-minor Increment the minor version when merged label Dec 15, 2022
@yarikoptic
Copy link
Member Author

yarikoptic commented Dec 16, 2022

eh -- that particular git-annex version (edit: not minimal but 10.20220927 the one to use by default) has its gotchas:

FAILED ../datalad/customremotes/tests/test_archives.py::test_basic_scenario - datalad.runner.exception.CommandError: CommandError: 'git -c diff.ignoreSubmodules=none annex get -c annex.retry=3 --json --json-error-messages --json-progress -c annex.dotfiles=true -- ' |;&%b5{}'"'"'"<>ΔЙקم๗あ .dbtc '' failed with exitcode 1 under /tmp/datalad_temp_tree_test_basic_scenariob7m7cqju [info keys: stdout_json]
> from datalad-archives...
Unable to access these remotes: datalad-archives
  Failed to fetch any archive containing MD5E-s3--202cb962ac59075b964b07152d234b70. Tried: ['MD5E-s182--39f5bb0f949956d83e4f9f04d2f94821.tar.gz']
  Failed to fetch any archive containing MD5E-s3--202cb962ac59075b964b07152d234b70. Tried: ['MD5E-s182--39f5bb0f949956d83e4f9f04d2f94821.tar.gz', 'MD5E-s182--39f5bb0f949956d83e4f9f04d2f94821.tar.gz']
  Failed to fetch any archive containing MD5E-s3--202cb962ac59075b964b07152d234b70. Tried: ['MD5E-s182--39f5bb0f949956d83e4f9f04d2f94821.tar.gz', 'MD5E-s182--39f5bb0f949956d83e4f9f04d2f94821.tar.gz'] [err: 'get: 1 failed']
FAILED ../datalad/customremotes/tests/test_archives.py::test_annex_get_from_subdir - datalad.runner.exception.CommandError: CommandError: 'git annex get -- ' |;&%b5{}'"'"'"<>ΔЙקم๗あ .datc '' failed with exitcode 1
= 2 failed, 1221 passed, 56 skipped, 4 xfailed, 19 warnings in 3218.12s (0:53:38) =

and completely stalls on nfs:

[gw0] [ 72%] PASSED ../datalad/support/tests/test_fileinfo.py::test_subds_path 
2319../datalad/support/tests/test_fileinfo.py::test_report_absent_keys 
2320
2321No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
2322Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#build-times-out-because-no-output-was-received
2323
2324The build has been terminated

so we would need to try some other for the default one -- may be the most recent available...

… 8.20210223 (in debian bullseye stable)

We have some tests failing for awhile with that older version:
- https://github.com/datalad/datalad/issues/6846
- datalad#6541
so going forward to version which should have those addressed and also having
other fixes and enhancements.

Closes datalad#6847

=== Do not change lines below ===
{
 "chain": [],
 "cmd": "bash -c 'sed -i -e '\"'\"'s,8.20200309,8.20210223,g'\"'\"' {outputs}'",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [
  "datalad/support/annexrepo.py",
  ".travis.yml"
 ],
 "pwd": "."
}
^^^ Do not change lines above ^^^
@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (eeb7313) 90.61% compared to head (f5c085f) 91.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7232      +/-   ##
==========================================
+ Coverage   90.61%   91.34%   +0.72%     
==========================================
  Files         325      325              
  Lines       43405    43423      +18     
  Branches        0     5821    +5821     
==========================================
+ Hits        39333    39665     +332     
+ Misses       4072     3743     -329     
- Partials        0       15      +15     
Files Coverage Δ
datalad/support/annexrepo.py 90.49% <100.00%> (+0.23%) ⬆️

... and 62 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adswa
Copy link
Member

adswa commented Mar 2, 2023

Whats you method of determining a git-annex version to try, @yarikoptic? Do you check package lists for different OS, or go through a list of annex releases, or something else entirely?

@yarikoptic
Copy link
Member Author

  • < available in debian stable
  • not buggy (for us)
  • > has feature I was looking for to support

Just hints ^^^, since I guess no clear strategy we have

.travis.yml Outdated Show resolved Hide resolved
@codeclimate
Copy link

codeclimate bot commented Oct 13, 2023

Code Climate has analyzed commit f5c085f and detected 0 issues on this pull request.

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-minor Increment the minor version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants