Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graphql): Support querying Posts and Queries #10502

Merged

Conversation

asikowitz
Copy link
Collaborator

I dislike this massive Constants.java file that just has hundreds of somewhat-organized constants. Feels like an enum in its own file would be significantly better. Then we could, for example, make a test to ensure ENTITY_TYPE_TO_NAME supports all defined entity types.

In any case, this should be an improvement, and let me query posts and queries

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label May 14, 2024
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol THANK YOU the lack of consistency in this file has always bothered me and i feel silly for not having made this change myself

@asikowitz asikowitz merged commit 7c4faf4 into datahub-project:master May 15, 2024
35 of 37 checks passed
@asikowitz asikowitz deleted the graphql-support-posts-queries branch May 15, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants