New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsolete `WebSocketChannel.new` documentation. #363

Merged

brianquinlan merged 2 commits into dart-lang:master from brianquinlan:constructordocs

May 17, 2024

Contributor

brianquinlan commented May 17, 2024

Fixes #358

I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Contribution guidelines:

See our contributor guide for general expectations for PRs.
Larger or significant changes should be discussed in an issue before creating a PR.
Contributions to our repos should follow the Dart style guide and use dart format.
Most changes should add an entry to the changelog and may need to rev the pubspec package version.
Changes to packages require corresponding tests.

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

brianquinlan added 2 commits

May 17, 2024 13:07


          Remove obsolete WebSocketChannel.new documentation.

34cfc28


          Update README.md

brianquinlan assigned natebosch

natebosch approved these changes

View reviewed changes

brianquinlan merged commit 45b8ce9 into dart-lang:master

6 of 7 checks passed

copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request


          [deps] rev args, http, mockito, web_socket_channel

5679c4d

Revisions updated by `dart tools/rev_sdk_deps.dart`.

args (https://github.com/dart-lang/args/compare/5c83bc9..cf90551):
  cf90551  Fri May 3 11:17:38 2024 -0700  Devon Carew  blast_repo fixes (dart-lang/args#274)
  72d6ef0  Wed May 1 23:57:25 2024 +0000  dependabot[bot]  Bump actions/checkout from 4.1.2 to 4.1.4 (dart-lang/args#271)
  e2e2023  Wed Apr 17 15:00:21 2024 -0700  Kevin Moore  Update to latest lints, require Dart 3.3 (dart-lang/args#270)
  8d66d21  Mon Apr 15 15:29:55 2024 +0000  dependabot[bot]  Bump dart-lang/setup-dart from 1.6.2 to 1.6.4 (dart-lang/args#268)

http (https://github.com/dart-lang/http/compare/76deb75..5c01453):
  5c01453  Fri May 17 15:41:46 2024 -0700  Brian Quinlan  Create a fake WebSocket implementation (dart-lang/http#1200)
  4d2f9f9  Fri May 17 15:19:58 2024 -0700  Brian Quinlan  Get ready to publish cronet_http 1.2.1 (dart-lang/http#1202)

mockito (https://github.com/dart-lang/mockito/compare/4be52e1..2302814):
  2302814  Fri May 17 09:51:20 2024 -0700  Googler  Stop using deprecated LibraryElement.isNonNullableByDefault

web_socket_channel (https://github.com/dart-lang/web_socket_channel/compare/8c77d6f..45b8ce9):
  45b8ce9  Fri May 17 15:19:29 2024 -0700  Brian Quinlan  Remove obsolete `WebSocketChannel.new` documentation. (dart-lang/web_socket_channel#363)

Change-Id: I654b0dce548e8b4ca1b98a626fddcb071cb1daae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/367147
Auto-Submit: Devon Carew <devoncarew@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment