Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the constructors for HtmlWebSocketChannel and IOWebSocketChannel #345

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

brianquinlan
Copy link
Contributor

@brianquinlan brianquinlan commented Apr 10, 2024

If we could remove HtmlWebSocketChannel and IOWebSocketChannel then we can reduce the size of package:web_socket_channel by ~850 LOC.

But this change might be too aggressive and will force some users to use the prerelease package:web_socket.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Copy link
Member

@natebosch natebosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if you decide to land this. I'm also fine holding off on the deprecation as discussed in the sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants