New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update Java interop document #5783
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are other mentions of the C bindings still available in the text. Please also change them.
src/content/interop/java-interop.md
Outdated
@@ -37,7 +37,6 @@ that uses `package:jnigen` to generate bindings for a simple class. | |||
|
|||
- JDK | |||
- [Maven][] | |||
- (Optional) [`clang-format`][] to format the generated C bindings | |||
|
|||
[Maven]: https://maven.apache.org/ | |||
[`clang-format`]: https://clang.llvm.org/docs/ClangFormat.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can also be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mentioned that there are other places where the C bindings are not removed.
However I cannot point you to them, as GitHub doesn't let me comment on unchanged lines.
It would be nice to allow changes, so we can commit to your fork.
So I'll try to review using links to the lines:
-To generate the Dart (and C) bindings, run `jnigen` and
+To generate the Dart bindings, run `jnigen` and
-you must build the dynamic libraries for `jni` and the generated C files.
+you must build the dynamic library for `jni`.
@HosseinYousefi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @utamori!
Pure Dart binding is now standard
This page needs to be updated so that newcomers are not confused
HosseinYousefi/jnigen_example#2
Contribution guidelines:
dart format
.<?code-excerpt
need to be updated in their source.dart
file as well.