"Specify members" and "access state" for mixins #5694
Conversation
|
Visit the preview URL for this PR (updated for commit 83a6a97): |
|
I'm done for the day and I'll be on vacation all week next week (and then working in AAR the week after that), but I'll take a look at this when I'm back. |
MaryaBelanger
added
review.tech
|
@MaryaBelanger, this looks great to me! I'm supportive of proceeding here and closing #4767. Thanks for picking this up! |
|
@munificent Friendly ping :) |
| dependencies are defined for the mixin. | ||
|
|
||
| ```dart | ||
| ? |
There was a problem hiding this comment.
Don't forget to fill this in. :)
There was a problem hiding this comment.
Oh! I'm sorry, I think I actually needed help with this example, not a review yet 😬
Would it look something like... this? Not sure what would go in the mixin
class Person {
final String _name;
Person(this._name);
String greet(String who) => 'Hello, $who. I am $_name.';
}
mixin Impersonator implements Person {
// what goes in here?
}
class Impostor with Impersonator {
String get _name => '';
String greet(String who) => 'Hi $who. Do you know who I am?';
}There was a problem hiding this comment.
Maybe something like:
abstract interface class Tuner {
void tuneInstrument();
}
mixin Guitarist implements Tuner {
void playSong() {
// Should be in tune first!
tuneInstrument();
print('Strums guitar majestically.');
}
}
class PunkRocker implements Tuner with Guitarist {
void tuneInstrument() {
print("Don't bother, being out of tune is punk rock.");
}
}?
| ### Use the `on` clause to declare a superclass | ||
|
|
||
| The `on` clause exists to define the type that `super` calls are resolved against. | ||
| So, you should only use it if you need to have a `super` call inside a mixin. |
| it to define the abstract method upon which its behavior depends. | ||
|
|
||
| ```dart | ||
| abstract mixin Musician { |
There was a problem hiding this comment.
No abstract needed (or allowed) here.
| dependencies are defined for the mixin. | ||
|
|
||
| ```dart | ||
| ? |
There was a problem hiding this comment.
Maybe something like:
abstract interface class Tuner {
void tuneInstrument();
}
mixin Guitarist implements Tuner {
void playSong() {
// Should be in tune first!
tuneInstrument();
print('Strums guitar majestically.');
}
}
class PunkRocker implements Tuner with Guitarist {
void tuneInstrument() {
print("Don't bother, being out of tune is punk rock.");
}
}?
This is an attempt to pick up #4767 and incorporate the this info-packed comment from #4834
It's pretty rough, I wasn't sure if "Specify members a mixin can call on itself" was an appropriate title for the new content, or if "accessing state" is interchangeable topic, or subtopic....?
I'm also totally missing an example (or anything more than a the single sentence about it, pulled from the above-linked comment).
@munificent hopefully this isn't totally off base? Lmk!
Apologies for overriding your work @KyleFin, I was having trouble working on your PR directly with the larger changes I wanted to do. Hopefully you can provide some feedback here!