Add code excerpts to new type promotion failures #5359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm still not sure how to implement the excerpts for the I know there's a way to print the actual error from the excerpts too (I think the Fixing common type problems page does it), so tbd on that too. |
MaryaBelanger
commented
Nov 18, 2023
src/tools/non-promotion-reasons.md
Outdated
| ```dart | ||
| import 'dart:math'; | ||
|
|
||
| abstract class C { | ||
| // ··· |
There was a problem hiding this comment.
Not huge fan of how this is automatically added anywhere the docregions end/restart in the excerpts file
There was a problem hiding this comment.
You can disable this by adding <?code-excerpt plaster="none"?> to the top of the file or in the excerpt you don't want to have it:
<?code-excerpt "file.dart (region)" plaster="none"?>
|
Visit the preview URL for this PR (updated for commit 19f966e): |
atsansone
added
review.await-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Excerpts added in #5246
Fixes #5350