Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dart 3] Class modifiers #4754

Merged
merged 14 commits into from
May 8, 2023
Merged

[Dart 3] Class modifiers #4754

merged 14 commits into from
May 8, 2023

Conversation

MaryaBelanger
Copy link
Contributor

@MaryaBelanger MaryaBelanger commented Apr 12, 2023

Reviewers:

  • New class modifiers page staged here
  • Minor changes to mixin page here
  • Added modifiers to Keywords page
  • Moved "Abstract classes" section off of "Classes" page and to "Class modifiers > abstract" section (didn't update text) here

Updates in progress after first review:

  • Need to change the examples so the code where extends, implements, etc is failing is clearly NOT in the same library where the modified class is declared.
  • The way I have it written now makes it seem like it's in the same library, in which case the modifiers wouldn't restrict anything.
  • Call out that the modifiers affect outside libraries more often and explicitly.
  • Need to change the first line here: "Dart has no interface keyword."

TODO (possibly separate PRs):


Fixes #4497
Fixes #4662
Fixes #4581

@github-actions
Copy link

github-actions bot commented Apr 12, 2023

Visit the preview URL for this PR (updated for commit 155c81c):

https://dart-dev--pr4754-class-modifiers-60un2t0u.web.app

(expires Mon, 15 May 2023 18:42:46 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d851bc446d3c4d7394c5406c6f07255afc7075f3

src/language/class-modifiers.md Show resolved Hide resolved
src/language/class-modifiers.md Outdated Show resolved Hide resolved
src/language/class-modifiers.md Outdated Show resolved Hide resolved
src/language/class-modifiers.md Outdated Show resolved Hide resolved
src/language/class-modifiers.md Outdated Show resolved Hide resolved
src/language/class-modifiers.md Outdated Show resolved Hide resolved
src/language/class-modifiers.md Outdated Show resolved Hide resolved
src/language/class-modifiers.md Show resolved Hide resolved
@MaryaBelanger MaryaBelanger added review.await-update Awaiting Updates after Edits and removed review.tech Awaiting Technical Review labels Apr 12, 2023
@MaryaBelanger MaryaBelanger removed the request for review from parlough April 12, 2023 20:56
src/language/classes.md Outdated Show resolved Hide resolved
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple of extra comments.

src/language/class-modifiers.md Outdated Show resolved Hide resolved
Copy link
Member

@munificent munificent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

src/language/class-modifiers.md Show resolved Hide resolved
src/language/class-modifiers.md Show resolved Hide resolved
src/language/class-modifiers.md Outdated Show resolved Hide resolved
src/language/class-modifiers.md Outdated Show resolved Hide resolved
src/language/class-modifiers.md Outdated Show resolved Hide resolved
src/language/class-modifiers.md Show resolved Hide resolved
src/language/class-modifiers.md Outdated Show resolved Hide resolved
Copy link
Contributor

@atsansone atsansone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MaryaBelanger : Solid work. Issues are:

  • Condition, then instruction per GSG.
  • Write in active voice per GSG.
  • Avoid parentheses per GSG.

I provided suggestions throughout.

src/language/class-modifiers.md Outdated Show resolved Hide resolved
src/language/class-modifiers.md Outdated Show resolved Hide resolved
src/language/class-modifiers.md Outdated Show resolved Hide resolved
src/language/class-modifiers.md Outdated Show resolved Hide resolved
src/language/class-modifiers.md Outdated Show resolved Hide resolved
src/language/class-modifiers.md Outdated Show resolved Hide resolved
src/language/class-modifiers.md Outdated Show resolved Hide resolved
src/language/class-modifiers.md Show resolved Hide resolved
src/language/class-modifiers.md Outdated Show resolved Hide resolved
src/language/class-modifiers.md Outdated Show resolved Hide resolved
@atsansone atsansone removed the review.copy Awaiting Copy Review label Apr 27, 2023
@MaryaBelanger MaryaBelanger added review.copy Awaiting Copy Review and removed review.await-update Awaiting Updates after Edits labels May 5, 2023
Copy link
Contributor

@atsansone atsansone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great update! A few issues, suggestions, and nits. Handle the issues and no need for another pass.

src/language/class-modifiers.md Outdated Show resolved Hide resolved
src/language/class-modifiers.md Outdated Show resolved Hide resolved
src/language/class-modifiers.md Outdated Show resolved Hide resolved
src/language/class-modifiers.md Outdated Show resolved Hide resolved
src/language/class-modifiers.md Outdated Show resolved Hide resolved
src/language/class-modifiers.md Outdated Show resolved Hide resolved
src/language/class-modifiers.md Show resolved Hide resolved
src/language/class-modifiers.md Outdated Show resolved Hide resolved
@atsansone atsansone removed their assignment May 5, 2023
@atsansone atsansone added st.RFM.% Ready to Merge but has suggestions and removed review.copy Awaiting Copy Review labels May 5, 2023
@MaryaBelanger MaryaBelanger merged commit 59c0280 into v3.0 May 8, 2023
6 checks passed
@parlough parlough deleted the class-modifiers branch May 23, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
st.RFM.% Ready to Merge but has suggestions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change link for interface on 'Keywords' page [Class modifiers] Language feature docs