Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Who uses Dart (updated) #4601

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

Who uses Dart (updated) #4601

wants to merge 15 commits into from

Conversation

MaryaBelanger
Copy link
Contributor

@MaryaBelanger MaryaBelanger commented Feb 15, 2023

This is a revision of #4577 (closing that in favor of this, added original author as co-author here) because I couldn't add changes to that contributor's fork. Thanks for getting this started @MikiPAUL!

Fixes #4144

Question for reviewers: I'm unsure why the page was taken down originally (archived here). Should I add that content to this PR?

MikiPAUL and others added 6 commits February 7, 2023 00:19
workiva typo fix

Co-authored-by: John Ryan <ryjohn@google.com>
workiva typo fix

Co-authored-by: John Ryan <ryjohn@google.com>
Co-authored-by: MikiPaul <mikipaul46@gmail.com>
@MaryaBelanger MaryaBelanger marked this pull request as ready for review February 15, 2023 23:46
@MaryaBelanger
Copy link
Contributor Author

@sfshaza2 @parlough I'm not 100% sold on this layout or organization, thoughts?

Copy link
Collaborator

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I don't really like the layout, either. Maybe wait for @mit-mit to return to ask him?

@atsansone atsansone added the review.copy Awaiting Copy Review label Feb 17, 2023

## Google

Dart is used in almost every product group at Google:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this "by almost every product groups"? (product groups are people?)


* [BMW][]
> "The BMW Group is establishing itself as a leading automotive app developer
Copy link
Member

@mit-mit mit-mit Feb 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're keeping quotes, I think they should be ones that talk about Dart somehow.

And, yeah, the layout of these quotes looks pretty odd in a list like this...

Alternatively, we could just change this to short descriptions, and pull them up a level, e.g.:

* [BMW][]: A total of 300 developers use Dart to deliver a unified *My BMW app* for iOS and Android.

[Google One]: https://one.google.com/about
[Cloud Search]: https://workspace.google.com/intl/en_in/products/cloud-search

## External
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I understand how this is "External"? Should it be "Other"?

Copy link
Contributor

@atsansone atsansone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your changes improve the page a lot. I would ask that some GSG changes be made. Thanks!

Comment on lines 9 to 11
The popular [Flutter toolkit][] is powered by the Dart language,
runtimes, tooling, and libraries. Over 500,000 Flutter apps for Android,
iOS, the web, and other targets, are all Dart-based.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: Active voice, per the GSG.

Suggested change
The popular [Flutter toolkit][] is powered by the Dart language,
runtimes, tooling, and libraries. Over 500,000 Flutter apps for Android,
iOS, the web, and other targets, are all Dart-based.
The Dart language and ecosystem powers the popular [Flutter toolkit][].
Developers have created more than 500,000 Flutter apps for Android,
iOS, the web, and other targets using Dart.


## Google

Dart is used in almost every product group at Google:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: Active voice.

Suggested change
Dart is used in almost every product group at Google:
Most product groups at Google use Dart:

Comment on lines 40 to 47
* The [Google Play Console][] lets app publishers market Android apps, and
is written completely in Dart.
* The [Google Ads][] team continues to grow, with hundreds of SWEs primarily
writing Dart code.
* The [Google Assistant][] team uses Flutter and Dart to drive the overall system
UI of their Smart Displays.
* Both the UI and much of the back-end code for [Google Nest Hub][] and Hub Max
devices are written in Dart.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: Active voice.

Suggested change
* The [Google Play Console][] lets app publishers market Android apps, and
is written completely in Dart.
* The [Google Ads][] team continues to grow, with hundreds of SWEs primarily
writing Dart code.
* The [Google Assistant][] team uses Flutter and Dart to drive the overall system
UI of their Smart Displays.
* Both the UI and much of the back-end code for [Google Nest Hub][] and Hub Max
devices are written in Dart.
* The Google Play team writes the [Google Play Console][] in Dart.
It lets app publishers market Android apps.
* The [Google Ads][] team continues to grow with hundreds of
SWEs writing Dart code.
* The [Google Assistant][] team uses Dart and Flutter to drive the
user interface of their Smart Displays.
* The Google Nest team wrote the user interface and much of the backend code
for [Google Nest Hub][] and Hub Max devices in Dart.

Comment on lines 59 to 60
Several other Google teams are currently rewritting their projects in Flutter.
In all, Google has thousands of developers writing millions of lines of code in Dart.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: Active voice. Also, spelling.

Suggested change
Several other Google teams are currently rewritting their projects in Flutter.
In all, Google has thousands of developers writing millions of lines of code in Dart.
The number of Google teams rewriting their projects in
Dart and Flutter continues to grow.
In all, Google has thousands of developers writing millions
of lines of code in Dart.

Comment on lines 76 to 82
Beyond Google and Flutter, many companies use Dart for building their applications:

* [Workiva's][] next-generation client applications for their productivity suite
are built with Dart.
* [Wrike][] uses the [AngularDart][] framework to develop project management tools.
* [Blossom][] is an agile project management tool built with Dart.
* And many more!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Should these not be combined with the quoted ones listed previously? If so, then move then and rewrite with active voice.

* And many more!

If you build production software with Dart and want to be included in this list,
please visit [our site's GitHub] to open an issue or pull request, thanks!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: Strike please per the GSG. Also, use GitHub as an adjective describing the repo, per the GSG.

Suggested change
please visit [our site's GitHub] to open an issue or pull request, thanks!
visit the [Dart.dev GitHub repo] to open an issue or pull request.

[Wrike]: https://www.wrike.com
[AngularDart]: https://angulardart.xyz/guide/setup
[Blossom]: https://blossom.co
[our site's GitHub]: https://github.com/dart-lang/site-www
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: To match the prior change.

Suggested change
[our site's GitHub]: https://github.com/dart-lang/site-www
[Dart.dev GitHub repo]: https://github.com/dart-lang/site-www

@atsansone atsansone added review.await-update Awaiting Updates after Edits and removed review.copy Awaiting Copy Review labels Feb 21, 2023
@atsansone atsansone marked this pull request as draft April 11, 2023 17:38
@mit-mit
Copy link
Member

mit-mit commented May 16, 2023

Hey @MaryaBelanger would be great to get this one landed now that we're past Dart 3.

@MaryaBelanger
Copy link
Contributor Author

@mit-mit sure thing, getting back to it now.

@atsansone atsansone added the st.WIP Issue in progress label Sep 1, 2023
@dart-github-bot
Copy link
Collaborator

dart-github-bot commented Feb 11, 2024

Visit the preview URL for this PR (updated for commit 3179e76):

https://dart-dev--pr4601-patch-1-ihemzf82.web.app

@dart-lang dart-lang deleted a comment from github-actions bot Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review.await-update Awaiting Updates after Edits st.WIP Issue in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update 'Who uses Dart' page
7 participants