New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Who uses Dart (updated) #4601
base: main
Are you sure you want to change the base?
Who uses Dart (updated) #4601
Conversation
workiva typo fix Co-authored-by: John Ryan <ryjohn@google.com>
workiva typo fix Co-authored-by: John Ryan <ryjohn@google.com>
Co-authored-by: MikiPaul <mikipaul46@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I don't really like the layout, either. Maybe wait for @mit-mit to return to ask him?
src/community/who-uses-dart.md
Outdated
|
||
|
||
Dart is used in almost every product group at Google: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this "by almost every product groups"? (product groups are people?)
src/community/who-uses-dart.md
Outdated
|
||
* [BMW][] | ||
> "The BMW Group is establishing itself as a leading automotive app developer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're keeping quotes, I think they should be ones that talk about Dart somehow.
And, yeah, the layout of these quotes looks pretty odd in a list like this...
Alternatively, we could just change this to short descriptions, and pull them up a level, e.g.:
* [BMW][]: A total of 300 developers use Dart to deliver a unified *My BMW app* for iOS and Android.
src/community/who-uses-dart.md
Outdated
[Google One]: https://one.google.com/about | ||
[Cloud Search]: https://workspace.google.com/intl/en_in/products/cloud-search | ||
|
||
## External |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I understand how this is "External"? Should it be "Other"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your changes improve the page a lot. I would ask that some GSG changes be made. Thanks!
src/community/who-uses-dart.md
Outdated
The popular [Flutter toolkit][] is powered by the Dart language, | ||
runtimes, tooling, and libraries. Over 500,000 Flutter apps for Android, | ||
iOS, the web, and other targets, are all Dart-based. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: Active voice, per the GSG.
The popular [Flutter toolkit][] is powered by the Dart language, | |
runtimes, tooling, and libraries. Over 500,000 Flutter apps for Android, | |
iOS, the web, and other targets, are all Dart-based. | |
The Dart language and ecosystem powers the popular [Flutter toolkit][]. | |
Developers have created more than 500,000 Flutter apps for Android, | |
iOS, the web, and other targets using Dart. |
src/community/who-uses-dart.md
Outdated
|
||
|
||
Dart is used in almost every product group at Google: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: Active voice.
Dart is used in almost every product group at Google: | |
Most product groups at Google use Dart: |
src/community/who-uses-dart.md
Outdated
* The [Google Play Console][] lets app publishers market Android apps, and | ||
is written completely in Dart. | ||
* The [Google Ads][] team continues to grow, with hundreds of SWEs primarily | ||
writing Dart code. | ||
* The [Google Assistant][] team uses Flutter and Dart to drive the overall system | ||
UI of their Smart Displays. | ||
* Both the UI and much of the back-end code for [Google Nest Hub][] and Hub Max | ||
devices are written in Dart. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: Active voice.
* The [Google Play Console][] lets app publishers market Android apps, and | |
is written completely in Dart. | |
* The [Google Ads][] team continues to grow, with hundreds of SWEs primarily | |
writing Dart code. | |
* The [Google Assistant][] team uses Flutter and Dart to drive the overall system | |
UI of their Smart Displays. | |
* Both the UI and much of the back-end code for [Google Nest Hub][] and Hub Max | |
devices are written in Dart. | |
* The Google Play team writes the [Google Play Console][] in Dart. | |
It lets app publishers market Android apps. | |
* The [Google Ads][] team continues to grow with hundreds of | |
SWEs writing Dart code. | |
* The [Google Assistant][] team uses Dart and Flutter to drive the | |
user interface of their Smart Displays. | |
* The Google Nest team wrote the user interface and much of the backend code | |
for [Google Nest Hub][] and Hub Max devices in Dart. |
src/community/who-uses-dart.md
Outdated
Several other Google teams are currently rewritting their projects in Flutter. | ||
In all, Google has thousands of developers writing millions of lines of code in Dart. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: Active voice. Also, spelling.
Several other Google teams are currently rewritting their projects in Flutter. | |
In all, Google has thousands of developers writing millions of lines of code in Dart. | |
The number of Google teams rewriting their projects in | |
Dart and Flutter continues to grow. | |
In all, Google has thousands of developers writing millions | |
of lines of code in Dart. |
src/community/who-uses-dart.md
Outdated
Beyond Google and Flutter, many companies use Dart for building their applications: | ||
|
||
* [Workiva's][] next-generation client applications for their productivity suite | ||
are built with Dart. | ||
* [Wrike][] uses the [AngularDart][] framework to develop project management tools. | ||
* [Blossom][] is an agile project management tool built with Dart. | ||
* And many more! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: Should these not be combined with the quoted ones listed previously? If so, then move then and rewrite with active voice.
src/community/who-uses-dart.md
Outdated
* And many more! | ||
|
||
If you build production software with Dart and want to be included in this list, | ||
please visit [our site's GitHub] to open an issue or pull request, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/community/who-uses-dart.md
Outdated
[Wrike]: https://www.wrike.com | ||
[AngularDart]: https://angulardart.xyz/guide/setup | ||
[Blossom]: https://blossom.co | ||
[our site's GitHub]: https://github.com/dart-lang/site-www |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: To match the prior change.
[our site's GitHub]: https://github.com/dart-lang/site-www | |
[Dart.dev GitHub repo]: https://github.com/dart-lang/site-www |
Hey @MaryaBelanger would be great to get this one landed now that we're past Dart 3. |
@mit-mit sure thing, getting back to it now. |
Visit the preview URL for this PR (updated for commit 3179e76): |
This is a revision of #4577 (closing that in favor of this, added original author as co-author here) because I couldn't add changes to that contributor's fork. Thanks for getting this started @MikiPAUL!
Fixes #4144
Question for reviewers: I'm unsure why the page was taken down originally (archived here). Should I add that content to this PR?