Update change_builder_dart.dart

[Devenik7]

Added support for named parameters while generating super method invocation

• Thanks for your contribution! Please replace this text with a description of what this PR is changing or adding and why, list any relevant issues, and review the contribution guidelines below.

---

• [YES] I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Contribution guidelines:

• See our contributor guide for general expectations for PRs.
• Larger or significant changes should be discussed in an issue before creating a PR.
• Contributions to our repos should follow the Dart style guide and use dart format.

Note that this repository uses Gerrit for code reviews. Your pull request will be automatically converted into a Gerrit CL and a link to the CL written into this PR. The review will happen on Gerrit but you can also push additional commits to this PR to update the code review.

[copybara-service]

Thank you for your contribution! This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at:

https://dart-review.googlesource.com/c/sdk/+/361282

Please wait for a developer to review your code review at the above link; you can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly.

Additional commits pushed to this PR will update both the PR and the corresponding Gerrit CL. After the review is complete on the CL, your reviewer will merge the CL (automatically closing this PR).

[srawlins]

Thanks for the PR! Can you add a test or a few tests. Likely with the same tests where @scheglov initially wrote the @override completion feature, in https://dart-review.googlesource.com/c/sdk/+/356640.

[Devenik7]

Got it.

Let me go through that original change and figure stuff out. First time contributing to Open Source.

[Devenik7]

Thanks for the PR! Can you add a test or a few tests. Likely with the same tests where @scheglov initially wrote the @override completion feature, in https://dart-review.googlesource.com/c/sdk/+/356640.

Hi @srawlins. I have added 2 tests, one for a method with only positional parameters and one for a method with both positional and named parameters.

Could you check and suggest if anything else is needed.

[copybara-service]

https://dart-review.googlesource.com/c/sdk/+/361282 has been updated with the latest commits from this pull request.

[copybara-service]

https://dart-review.googlesource.com/c/sdk/+/361282 has been updated with the latest commits from this pull request.

[srawlins]

The new tests seem to fail. See https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8751123390552515201/+/u/test_results/new_test_failures__logs_

Also, we sort our files alphabetically (just the analyzer team), which can be done in an IDE with a "sort members" command. See the same log for "class_body_test.dart" being an "Unsorted file".

[Devenik7]

Let me check that

[copybara-service]

https://dart-review.googlesource.com/c/sdk/+/361282 has been updated with the latest commits from this pull request.

[srawlins]

I'm still seeing a failure at https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8750577436591192721/+/u/test_results/new_test_failures__logs_, see "test_class_method_without_namedParameters".

[Devenik7]

Hi @srawlins. Have been busy with my day job. I have checked the errors and understood the changes needed.

Will get back (probably over the weekend) with the changes.

[mraleph]

I assume this is stale. Please reopen if not.