Fix missing redirect for http POST on 307 & 308 #54032
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
chore: add extended comment |
|
/cc @brianquinlan |
|
@bschmalb Please take a moment to sign CLA - otherwise we can't merge your PR. Thanks. |
|
done @mraleph |
|
Thank you for your contribution! This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at: https://dart-review.googlesource.com/c/sdk/+/337520 Please wait for a developer to review your code review at the above link; you can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly. Additional commits pushed to this PR will update both the PR and the corresponding Gerrit CL. After the review is complete on the CL, your reviewer will merge the CL (automatically closing this PR). |
|
https://dart-review.googlesource.com/c/sdk/+/337520 has been updated with the latest commits from this pull request. |
|
I left more detailed comments at https://dart-review.googlesource.com/c/sdk/+/337520 but the TL;DR version is that I don't think that RFC-2616 allows redirects for POST requests, except where the status code is 303. |
|
As described in the issue #54001 there is a rfc-standart https://www.rfc-editor.org/rfc/rfc7538 that describes the redirect for 307 and 308 status codes. @brianquinlan |
|
https://dart-review.googlesource.com/c/sdk/+/337520 has been updated with the latest commits from this pull request. |
|
I assume this is stale. Please reopen if not. |
Fixes issue: #54001
Contribution guidelines:
- See our [contributor guide](https://github.com/dart-lang/sdk/blob/main/CONTRIBUTING.md) for general expectations for PRs. - Larger or significant changes should be discussed in an issue before creating a PR. - Contributions to our repos should follow the [Dart style guide](https://dart.dev/guides/language/effective-dart) and use dart format. Note that this repository uses Gerrit for code reviews. Your pull request will be automatically converted into a Gerrit CL and a link to the CL written into this PR. The review will happen on Gerrit but you can also push additional commits to this PR to update the code review.