Skip to content

Commit

Permalink
[test_runner] Reduce timeouts.
Browse files Browse the repository at this point in the history
We've roughly doubled bot speeds; half timeouts to provide pressure against this simply getting filled with slower tests.

Change-Id: I812da7adc6c08e6d484732c2558e0d3f63b2694a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/364385
Reviewed-by: Alexander Aprelev <aam@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
  • Loading branch information
rmacnak-google authored and Commit Queue committed Apr 26, 2024
1 parent f68a70d commit f020078
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/test_runner/lib/src/configuration.dart
Expand Up @@ -245,7 +245,7 @@ class TestConfiguration {
arch: architecture,
system: system);

_timeout = 60 * compilerMultiplier * runtimeMultiplier;
_timeout = 30 * compilerMultiplier * runtimeMultiplier;
}
}

Expand Down
3 changes: 3 additions & 0 deletions pkg/test_runner/lib/src/runtime_configuration.dart
Expand Up @@ -356,6 +356,9 @@ class DartVmRuntimeConfiguration extends RuntimeConfiguration {
if (arch == Architecture.ia32) {
multiplier *= 2;
}
if (arch == Architecture.x64 && system == System.mac) {
multiplier *= 2; // Older, slower machines.
}

if (mode.isDebug) {
multiplier *= 2;
Expand Down
2 changes: 2 additions & 0 deletions runtime/tests/vm/vm.status
Expand Up @@ -13,6 +13,7 @@ cc/IsolateReload_PendingUnqualifiedCall_InstanceToStatic: Fail # Issue 32981
cc/IsolateReload_PendingUnqualifiedCall_StaticToInstance: Fail # Issue 32981
cc/TTS_STC_ManyAsserts: Pass, Slow # Generates 10k classes that are put into an STC via assert checks.
dart/analyze_snapshot_binary_test: Pass, Slow # Runs various subprocesses for testing AOT.
dart/async_igoto_threshold_flag_test: Pass, Slow
dart/boxmint_test: Pass, Slow # Uses slow path
dart/byte_array_optimized_test: Pass, Slow
dart/byte_array_test: Pass, Slow # Uses --opt-counter-threshold=10
Expand All @@ -30,6 +31,7 @@ dart/print_object_layout_test: Pass, Slow # Spawns several subprocesses
dart/regress32619_test: Pass, Slow
dart/slow_path_shared_stub_test: Pass, Slow # Uses --shared-slow-path-triggers-gc flag.
dart/snapshot_version_test: Skip # This test is a Dart1 test (script snapshot)
dart/spawn_uri_aot_test: Pass, Slow # Runs various subprocesses for testing AOT.
dart/stack_overflow_shared_test: Pass, Slow # Uses --shared-slow-path-triggers-gc flag.

[ $arch == ia32 ]
Expand Down
1 change: 1 addition & 0 deletions tests/co19/co19-runtime.status
Expand Up @@ -3,6 +3,7 @@
# BSD-style license that can be found in the LICENSE file.

[ $system == windows ]
LibTest/io/FileSystemModifyEvent/contentChanged_A01_t01: Pass, Slow
LibTest/io/ProcessResult/exitCode_A01_t02: Skip # Issue 32138
LibTest/io/Stdin/readByteSync_A01_t01: Skip # Issue 32138
LibTest/io/Stdin/readByteSync_A01_t02: Skip # Issue 32138
Expand Down

0 comments on commit f020078

Please sign in to comment.