Skip to content

Commit

Permalink
Mark file system event tests as slow.
Browse files Browse the repository at this point in the history
Restore timeout for windows-arm64, which did not get faster.

Change-Id: I9f032c25fc69454929348f0589d35200a4728142
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/364625
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
  • Loading branch information
rmacnak-google authored and Commit Queue committed Apr 26, 2024
1 parent 6357371 commit 1ff4f72
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
5 changes: 3 additions & 2 deletions pkg/test_runner/lib/src/runtime_configuration.dart
Expand Up @@ -356,8 +356,9 @@ class DartVmRuntimeConfiguration extends RuntimeConfiguration {
if (arch == Architecture.ia32) {
multiplier *= 2;
}
if (arch == Architecture.x64 && system == System.mac) {
multiplier *= 2; // Older, slower machines.
if ((arch == Architecture.x64 && system == System.mac) ||
(arch == Architecture.arm64 && system == System.win)) {
multiplier *= 2; // Slower machines.
}

if (mode.isDebug) {
Expand Down
4 changes: 3 additions & 1 deletion tests/co19/co19-runtime.status
Expand Up @@ -2,8 +2,10 @@
# for details. All rights reserved. Use of this source code is governed by a
# BSD-style license that can be found in the LICENSE file.

LibTest/io/FileSystemModifyEvent/*: Pass, Slow
LibTest/io/FileSystemMoveEvent/*: Pass, Slow

[ $system == windows ]
LibTest/io/FileSystemModifyEvent/contentChanged_A01_t01: Pass, Slow
LibTest/io/ProcessResult/exitCode_A01_t02: Skip # Issue 32138
LibTest/io/Stdin/readByteSync_A01_t01: Skip # Issue 32138
LibTest/io/Stdin/readByteSync_A01_t02: Skip # Issue 32138
Expand Down

0 comments on commit 1ff4f72

Please sign in to comment.