Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write .dart_tool/pub/workspace_ref.json #4240

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Write .dart_tool/pub/workspace_ref.json #4240

merged 1 commit into from
Apr 26, 2024

Conversation

sigurdm
Copy link
Contributor

@sigurdm sigurdm commented Apr 25, 2024 •
edited

This file can be used for the fast path of ensureUpToDate to find the root pubspec.yaml without parsing the intermediate pubspec.yaml files.

Part of #4239
Related to dart-lang/sdk#55548

@kevmoo
Copy link
Member

kevmoo commented Apr 25, 2024

is pub a reserved package name? In general, .dart_tool/XYZ/ XYZ should be namespaced by a package name to minimize change of collisions

@sigurdm
Copy link
Contributor Author

sigurdm commented Apr 26, 2024

Yes it is reserved: https://github.com/dart-lang/pub-dev/blob/720c134eab618ed62f7a09bfe8eef1577d6a1a16/app/lib/package/overrides.dart#L29

@sigurdm
Copy link
Contributor Author

sigurdm commented Apr 26, 2024

Also pub already writes to this folder (snapshots for dart run).

@sigurdm sigurdm merged commit 0e7446a into dart-lang:master Apr 26, 2024
23 checks passed
@sigurdm sigurdm mentioned this pull request May 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasfj jonasfj jonasfj approved these changes

@szakarias szakarias Awaiting requested review from szakarias

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sigurdm @kevmoo @jonasfj