Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow globs in workspace definitions #4223

Closed
wants to merge 1 commit into from

Conversation

sigurdm
Copy link
Contributor

@sigurdm sigurdm commented Apr 15, 2024

Part of #4127

Initially we thought we would not allow globs, because resolving them would be on the hot path of ensureResolutionUpToDate and thus dart run.

But I think we are getting close to the conclusion that the fast path of ensureResolutionUpToDate only should depend on .dart_tool/package_config.json, not parsing and resolving pubspec.yamls - thus we can allow globs.

There is still the issue that executableForCommand needs to know if a package is a direct dependency or not. We might want to solve that issue before landing this. Discussing in #4222

@sigurdm
Copy link
Contributor Author

sigurdm commented Apr 17, 2024

We've decided not to do this in the first incantation of workspaces.

@sigurdm sigurdm closed this Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant