Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show parent pubspecs when a pubspec could not be found. #4197

Merged
merged 5 commits into from
Apr 8, 2024
Merged

Show parent pubspecs when a pubspec could not be found. #4197

merged 5 commits into from
Apr 8, 2024

Conversation

sigurdm
Copy link
Contributor

@sigurdm sigurdm commented Mar 25, 2024

Related to #4127

@sigurdm sigurdm requested a review from jonasfj March 25, 2024 14:35
jonasfj
jonasfj reviewed Apr 5, 2024
View reviewed changes
Copy link
Member

@jonasfj jonasfj left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but you seem to have included a few extra lines not related to this PR. I assume this is about improving the error message?

lib/src/package.dart Outdated Show resolved Hide resolved
lib/src/package.dart Outdated Show resolved Hide resolved
@sigurdm sigurdm closed this Apr 5, 2024
@sigurdm sigurdm reopened this Apr 5, 2024
@sigurdm sigurdm merged commit 9d6cd8a into dart-lang:master Apr 8, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasfj jonasfj jonasfj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sigurdm @jonasfj