Support lfs and submodules #3806
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also call "submodule update --init --recursive" to support submodules.
|
TODO: write a spec for the cache layout (this needs to include the old layout, naming conventions etc). This can live as an md file in |
|
(after offline discussion) Let's try this without the submodule support (just yet) there are still some open questions. It is possible that use of sub-modules will conflict with future ideas, such as resolving by version-tags... |
|
We should also find out and document which version of git we require for this to work. |
|
We should find out how far back git includes worktree support, and require that as a minimum git version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a worktree instead of a full clone to check out each revision for a git source.
This seems to enable git lfs to just work somehow
This should also reduce the disk consumption, as we don't have to repeat the
.gitfolder.Also run
git submodule update --init --recursivein each worktree after checking it out.This should enable submodules. It is a nop, and quite fast if there are no submodules.
Still some kinks to work out with backwards compatibility, but I think it could be made to work at least upwards. (doing
cache repairwith an older dart sdk will probably break).