Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store pending ModerationCase before sending email on the report page. #7660

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented Apr 18, 2024

  • New moderation and report processing flow #7535
  • As the receipt of a report is complete only if we are able to successfully send an email to the reporter, and we want to have immediate feedback upon request, we will have some kind of ambiguity here. The PR chooses that some loose ModerationCase entities may be in the Datastore that we may not send emails for, and thus we don't start investigations. However, in such cases the reporter won't get any positive acknowledgement of the report, and they may (and should) retry it later.
  • The loose ModerationCase entities must be reconciled manually. We could delete them if the mail sending fails, but better to fail safely and let it be a manual review of such entries.

@isoos isoos requested review from jonasfj and sigurdm April 18, 2024 16:49
@isoos isoos merged commit f18f1bd into dart-lang:master Apr 22, 2024
31 checks passed
@isoos isoos deleted the report-case branch April 22, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants