Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModerationCase entity #7614

Merged
merged 4 commits into from
Apr 9, 2024
Merged

ModerationCase entity #7614

merged 4 commits into from
Apr 9, 2024

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented Apr 4, 2024

@isoos isoos requested a review from jonasfj April 4, 2024 15:08
Copy link
Contributor

@sigurdm sigurdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is code generation being run for this file yet? (I don't see a .g file)...

/// - `moderation-upheld`, if this is an appeal (kind = appeal) of a notification
/// where we applied content moderation, and we decided to uphold that decision.
/// - `moderation-reverted`, if this is an appeal (kind = appeal) of a notification
/// where we applied content moderation, and we decided to revert that decision.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps document the null case.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we shouldn't allow null? E.g. pending could indicate the in-progress state, and it is also possible to filter for it...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SG

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IF we want a pending thing, we should rename it status.

For querying it's probably fine to have a pending value.

@isoos
Copy link
Collaborator Author

isoos commented Apr 5, 2024

Is code generation being run for this file yet? (I don't see a .g file)...

This does not have any API-exposed use case, there is no need to generate JSON serialization.

app/lib/admin/models.dart Outdated Show resolved Hide resolved
/// - `moderation-upheld`, if this is an appeal (kind = appeal) of a notification
/// where we applied content moderation, and we decided to uphold that decision.
/// - `moderation-reverted`, if this is an appeal (kind = appeal) of a notification
/// where we applied content moderation, and we decided to revert that decision.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IF we want a pending thing, we should rename it status.

For querying it's probably fine to have a pending value.

isoos and others added 2 commits April 5, 2024 13:55
Co-authored-by: Jonas Finnemann Jensen <jopsen@gmail.com>
@isoos
Copy link
Collaborator Author

isoos commented Apr 5, 2024

IF we want a pending thing, we should rename it status.

Maybe it is better to reduce the possible values to pending, no-action, upheld, reverted, without the ${kind} classification?

@isoos isoos merged commit 6e299e0 into dart-lang:master Apr 9, 2024
31 checks passed
@isoos isoos deleted the moderation-case branch April 9, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants