Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wildcard-variables] Add 'no_wildcard_variable_uses' lint to breaking change section. #3785

Merged
merged 1 commit into from May 9, 2024

Conversation

kallentu
Copy link
Member

@kallentu kallentu commented May 7, 2024

This PR adds information about the existing no_wildcard_variable_uses lint which should help the migration of the wildcards feature.

It's already a core lint and should be enabled in most projects, meaning that the breakage for the wildcards feature should be small.

Anyways, writing is hard -- so let me know if I should add/remove/change something. Thanks 😄

@kallentu kallentu requested review from munificent, pq and eernstg May 7, 2024 21:03
Copy link
Member

@pq pq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bob or Eric may suggest some word-smithing but content LGTM!

Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Just adding a comment that we might want to use a lint which is more precisely targeted at the references to _ which will actually break.

working/wildcards/feature-specification.md Show resolved Hide resolved
@kallentu kallentu merged commit ff28cb6 into main May 9, 2024
3 checks passed
@kallentu kallentu deleted the wildcards-add-lint branch May 9, 2024 17:19
Copy link
Member

@munificent munificent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants