Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove spurious reference to ~/ in constant rule #3525

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove spurious reference to ~/ in constant rule #3525

wants to merge 1 commit into from

Conversation

eernstg
Copy link
Member

@eernstg eernstg commented Dec 19, 2023

The PR #3495 changed the rule about e1 ~/ e2 as a constant expression. This PR removes a spurious reference to the operator symbol ~/ (it should no longer be mentioned in the rule which doesn't cover e1 ~/ e2 any more).

@eernstg
Copy link
Member Author

eernstg commented Dec 19, 2023

Thanks!

lrhn
lrhn approved these changes Dec 22, 2023
View reviewed changes
Copy link
Member

@lrhn lrhn left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it was in the num category already too.

@eernstg
Copy link
Member Author

eernstg commented Dec 22, 2023

Yes, the rule about ~/ was moved to the case about int-or-double in #3495, this PR was just removing a now-obsolete reference to the operator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrhn lrhn lrhn approved these changes

@natebosch natebosch natebosch approved these changes

Assignees

@natebosch natebosch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eernstg @lrhn @natebosch