Specify null safety subtyping #3515
Open
+504
−403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eernstg
force-pushed
the
specify_null_safety_subtyping_dec23
branch
from
082c391
to
a9f4886
Compare
lrhn
reviewed
Dec 22, 2023
| which means that this seemingly expensive step can be confined to some extent.% | ||
| } | ||
| \commentary{% | ||
| Note that this rule is admissible, and can be safely elided if desired.% |
There was a problem hiding this comment.
Define "admissible". It's a term of art not used elsewhere in the specification, so we cannot assume the reader to be familiar with it.
eernstg
force-pushed
the
specify_null_safety_subtyping_dec23
branch
from
a9f4886
to
0fd9980
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the null-safety updates from #2605 (the overall null-safety PR) that are concerned with subtyping. The intention is that we process and land this PR, and #2605 will then be made smaller when it is rebased over this one, thus allowing us to deal with the null-safety update in smaller portions.