Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrated cupertino_http with package_http_profile #1079

Open
wants to merge 32 commits into
base: master
Choose a base branch
from

Conversation

brianquinlan
Copy link
Collaborator

@brianquinlan brianquinlan commented Dec 14, 2023


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@brianquinlan brianquinlan marked this pull request as draft December 14, 2023 16:14
@github-actions github-actions bot added the package:cupertino_http Issues related to package:cupertino_http label Dec 14, 2023
@github-actions github-actions bot added the type-infra A repository infrastructure change or enhancement label May 9, 2024
@brianquinlan brianquinlan marked this pull request as ready for review May 9, 2024 22:02
@@ -28,6 +28,7 @@ dev_dependencies:
sdk: flutter
http_client_conformance_tests:
path: ../../http_client_conformance_tests/
http_profile: ^0.1.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're adding a dependency on package:http_profile, I believe

environment:
  sdk: ^3.2.0
  flutter: '>=3.16.0'

should be changed to

environment:
  sdk: ^3.4.0
  flutter: '>=3.22.0'


* Add integration to the
[DevTools "Network" tab](https://docs.flutter.dev/tools/devtools/network).
Copy link
Member

@derekxu16 derekxu16 May 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[DevTools "Network" tab](https://docs.flutter.dev/tools/devtools/network).
[DevTools Network View](https://docs.flutter.dev/tools/devtools/network).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:cupertino_http Issues related to package:cupertino_http type-infra A repository infrastructure change or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants