Eagerly bind AssignPiece if it can't block split and operands don't fit. #1477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If neither of the two operands to an AssignPiece can be block formatted, and they contain newlines or the whole thing doesn't fit the page width, then the AssignPiece will definitely split at the operator. This optimization helps a few rare cases (like deeply nested curried-style functions) from going pathological. I noticed it when migrating one of the regression tests over. It doesn't have a noticeable affect on formatting the whole Flutter repo, but it doesn't hurt either.
natebosch
reviewed
May 7, 2024
natebosch
approved these changes
May 7, 2024
kallentu
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If neither of the two operands to an AssignPiece can be block formatted, and they contain newlines or the whole thing doesn't fit the page width, then the AssignPiece will definitely split at the operator.
This optimization helps a few rare cases (like deeply nested curried-style functions) from going pathological. I noticed it when migrating one of the regression tests over.
It doesn't have a noticeable affect on formatting the whole Flutter repo, but it doesn't hurt either.