Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure the run button displays on the RHS in rtl locales #2754

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Conversation

devoncarew
Copy link
Member

  • ensure the run button displays on the RHS in rtl locales

This should fix the issue with the run and format buttons seen in #2748.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@devoncarew
Copy link
Member Author

devoncarew commented Dec 13, 2023

Before this PR (for an rtl locale):

Screenshot 2023-12-13 at 3 07 04 PM

With this PR (for an rtl locale):

Screenshot 2023-12-13 at 3 07 17 PM

@devoncarew devoncarew mentioned this pull request Dec 13, 2023
1 task
Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

🕺 ➡️

@devoncarew devoncarew merged commit 0ed1acc into main Dec 14, 2023
4 checks passed
@devoncarew devoncarew deleted the rtl_fix branch December 14, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants