Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add localization #2748
base: main
Are you sure you want to change the base?
Add localization #2748
Changes from 6 commits
c8fa740
4a41aba
f84ae43
ebd0586
5d01ab4
58aef90
948bd91
4852c20
3a8333c
c52f6e3
ba05735
3cc8300
fe95aa0
deea7c0
58ba66b
77cbabd
3fa10c6
4a6497a
ba00e09
dc42857
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not for this PR, but it may be nice to have some CI checks that this list matches the arbs files available, and the list of json files in the flutter assets section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how Flutter currently handles this matching between
supportedLocales
and actually existing.arb
files. @HansMuller?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When to prefer
MessageLocalizations.of(context)
overcontext.messageLocalizations
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not for this PR, but we should add some docs to the repo about how to contribute a new localization; this will be a good way to get more people involved.