#2643. Remove some of 2.6 libraries, update/remove tests using them #2650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eernstg
reviewed
May 8, 2024
There was a problem hiding this comment.
Looks good!
However, I couldn't spot any real dependency on legacy types in a couple of cases, PTAL:
I can't see why the List length setter test LanguageFeatures/nnbd/weak/list_length_t02.dart shouldn't be valid today. Similarly for LanguageFeatures/nnbd/weak/list_length_t04.dart, using just unsound execution but no legacy code. Is that true?
I also got the impression that LanguageFeatures/nnbd/weak/nullability_definitions_A01_t08.dart could be updated to work the same, but not use legacy code. Or would that just duplicate some other test?
|
Thank you for the detailed review. |
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
May 13, 2024
2024-05-10 sgrekhov22@gmail.com dart-lang/co19#2641. Experimental flag renamed (dart-lang/co19#2655) 2024-05-10 sgrekhov22@gmail.com dart-lang/co19#2641. Add more test cases to the existing wildcard tests (dart-lang/co19#2654) 2024-05-10 sgrekhov22@gmail.com dart-lang/co19#2643. Remove some of 2.6 libraries, update/remove tests using them (dart-lang/co19#2650) 2024-05-08 sgrekhov22@gmail.com dart-lang/co19#2643. Remove more legacy tests from LanguageFeatures/nnbd/weak/overriding (dart-lang/co19#2648) 2024-05-08 sgrekhov22@gmail.com dart-lang/co19#2643. Remove tests checking exports from 2.6 libraries (dart-lang/co19#2651) 2024-05-08 sgrekhov22@gmail.com dart-lang/co19#2643. Remove legacy types from subtyping tests (dart-lang/co19#2652) 2024-05-08 sgrekhov22@gmail.com dart-lang/co19#2641. Add experimental flag to wildcards tests (dart-lang/co19#2653) 2024-05-07 sgrekhov22@gmail.com dart-lang/co19#2643. Remove more legacy tests from LanguageFeatures/nnbd/weak/overriding (dart-lang/co19#2647) 2024-05-07 sgrekhov22@gmail.com dart-lang/co19#2643. Remove legacy tests from LanguageFeatures/Generic-functions-as-type-args (dart-lang/co19#2645) 2024-05-07 sgrekhov22@gmail.com dart-lang/co19#2631. Add tests checking access to local declaration named `_` (dart-lang/co19#2639) 2024-05-07 sgrekhov22@gmail.com dart-lang/co19#2643. Remove legacy tests from TypeSystem/type-normalization (dart-lang/co19#2646) 2024-05-07 sgrekhov22@gmail.com dart-lang/co19#2643. Remove override checking tests in case a legacy class extending an opted-in class (dart-lang/co19#2644) 2024-05-07 sgrekhov22@gmail.com Fixes dart-lang/co19#2638. Add extension methods test for type aliases (dart-lang/co19#2640) 2024-05-07 sgrekhov22@gmail.com dart-lang/co19#2142. Add tests checking type parameter vs representation variable name conflict (dart-lang/co19#2642) 2024-05-03 devoncarew@google.com blast_repo fixes (dart-lang/co19#2637) Change-Id: I3f9f18065b555634b621100bdc375b40a75539cf Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/365821 Reviewed-by: Erik Ernst <eernst@google.com> Commit-Queue: Alexander Thomas <athom@google.com> Reviewed-by: Alexander Thomas <athom@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.